- User Since
- May 28 2019, 10:18 PM (15 w, 4 d)
Tue, Aug 27
It makes sense.
Sun, Aug 25
Thank you for the "js way" to modify the indentation. I will have a look at this tomorrow.
Set the section to 3D and few style changes.
Wed, Aug 21
I think I don't have the rights to apply a diff, the reviewers have to do so.
AFAIK, the patch is OK for everyone and setting gregormi as the author too.
Mon, Aug 19
Set the regexp button tooltip.
Aug 15 2019
Ok, so as long as no one has another suggestion, the only remaining task is to choose a short tooltip.
English is not my mother tongue (I'm even capable of writing hoodbook instead of handbook) so please help me before I update the patch.
In order to keep it short, I suggest to give a hint about a single way to add a snippet, not both, example:
see available patterns in :
find or replace fields > right click > add
snippets available in the text fields right buttons
I tried to remove inline comments.
From what I understood, there are still open questions :
-Do we keep the new buttons in the lineedit and the "snippets" in it and/or do we keep the snippets in the right click / add menu ? The snippets are in both menus for now. I have no personal opinion but I don't think I would have right clicked a lineedit if I didn't read the comments.
-Do we shorten the regexp button tooltip ? I prefer to do so.
-Do we update the Kate hoodbook ?
Jul 14 2019
Ok. Note that the layout is still the one you currently use when toolview is at the bottom (when toolview.width >= toolview.height)
I agree about reverting the search.ui changes. I made these changes when trying the 2nd layout but they do not make any sense now. Fixed.
The double space was unintentional and it is fixed.
Jul 4 2019
Another way to avoid indented empty line is to clear the trailing spaces/indentation when pressing enter while the cursor is at the end of a line containing only spaces or \t. This can lead to a nightmare though if someone want to keep trailing spaces...
Jul 1 2019
This is the patch corresponding to the third suggestion screenshot.
I also modified the search.ui file in order to change some QPushButton to QToolButton. This way, all "icon only" buttons have the same look and it allows to hide the other buttons text (this was used in the second suggestion).
Jun 25 2019
I added a screenshot based on the last comment. Buttons are grouped depending on their relation to "find" (including the show search options button) or to replace/result (including Expand result and Add Tab).
Jun 24 2019
You are right, the "Search" and "Next" buttons should be grouped with the search combo box and the same applies for "Replace" and "Replace Checked". On the other hand, I think it would be nice to have large find and replace combo boxes. Thus, we don't want to eat too much space with other widgets in the same row.
I suggest the following :
- add icons and help tooltips to the "Replace" and "Replace Checked" buttons
- when the view is narrow, move the search combo box along with the "Search" and "Next" buttons on their own row; remove the button texts; remove the "Find" label. The same applies for the replace group.
- when the view is large, restore the original view