This feature is already implemented in kwrite. The default undo/redo shortcuts in Kate are Ctrl+E / Ctrl+Shift+E.

• "There is already a way to do this on KTextEditor". The existing code seems to update the position stack only after editing a document but I will give it a try, thanks . It is a feature I needed for a long time and according to the Bug 409940, I'm not the only one, I just never took the time to dig into it. The "delete" and "page end" keys are too close on my keyboard...

Thanks for the feedback, I managed to reproduce this using "go to definition" and will investigate.
I only tried to manage long jumps (page end, mouse click, etc.): pressing 77 times the up arrow was not meant to add any item to the undo stack but reading the code, I realized that it actually adds 7 items of 11 lines jumps. This is probably not what we want.
It is possible to discard small jumps by comparing the new position to the last *view* position instead of the last *undo stack* position. Any suggestion ?

It makes sense.

Yup,
Mickael Bosch
mickael.bosch@linux.com
Thanks,

Thank you for the "js way" to modify the indentation. I will have a look at this tomorrow.

Set the section to 3D and few style changes.

I think I don't have the rights to apply a diff, the reviewers have to do so.
AFAIK, the patch is OK for everyone and setting gregormi as the author too.

Set the regexp button tooltip.

Ok, so as long as no one has another suggestion, the only remaining task is to choose a short tooltip.
English is not my mother tongue (I'm even capable of writing hoodbook instead of handbook) so please help me before I update the patch.
In order to keep it short, I suggest to give a hint about a single way to add a snippet, not both, example:

see available patterns in :
find or replace fields > right click > add

or

snippets available in the text fields right buttons

I tried to remove inline comments.
From what I understood, there are still open questions :
-Do we keep the new buttons in the lineedit and the "snippets" in it and/or do we keep the snippets in the right click / add menu ? The snippets are in both menus for now. I have no personal opinion but I don't think I would have right clicked a lineedit if I didn't read the comments.
-Do we shorten the regexp button tooltip ? I prefer to do so.
-Do we update the Kate hoodbook ?

Ok. Note that the layout is still the one you currently use when toolview is at the bottom (when toolview.width >= toolview.height)

I agree about reverting the search.ui changes. I made these changes when trying the 2nd layout but they do not make any sense now. Fixed.
The double space was unintentional and it is fixed.

Another way to avoid indented empty line is to clear the trailing spaces/indentation when pressing enter while the cursor is at the end of a line containing only spaces or \t. This can lead to a nightmare though if someone want to keep trailing spaces...

This is the patch corresponding to the third suggestion screenshot.
I also modified the search.ui file in order to change some QPushButton to QToolButton. This way, all "icon only" buttons have the same look and it allows to hide the other buttons text (this was used in the second suggestion).

I added a screenshot based on the last comment. Buttons are grouped depending on their relation to "find" (including the show search options button) or to replace/result (including Expand result and Add Tab).

You are right, the "Search" and "Next" buttons should be grouped with the search combo box and the same applies for "Replace" and "Replace Checked". On the other hand, I think it would be nice to have large find and replace combo boxes. Thus, we don't want to eat too much space with other widgets in the same row.
I suggest the following :

• add icons and help tooltips to the "Replace" and "Replace Checked" buttons
• when the view is narrow, move the search combo box along with the "Search" and "Next" buttons on their own row; remove the button texts; remove the "Find" label. The same applies for the replace group.
• when the view is large, restore the original view