gcc naming conflict

Authored by mickaelbo on Aug 27 2019, 5:32 PM.

Description

gcc naming conflict

Summary:
With gcc 7.4.0 (and maybe some other versions), "major" and "minor" are set as macro and expand to "gnu_dev_major" and "gnu_dev_minor".
See: https://bugzilla.redhat.com/show_bug.cgi?id=130601

These strings are used in the affected file for variable naming.
The attached patch undef the gcc renaming.

A syntax-highlighting user, Jonathan, reported the issue, provided the patch and tested it after trying to compile the project when the last commit was authored by me. Thank you Jonathan.

Test Plan: The compilation shall not fail with gcc 7.4.0.

Reviewers: Framework: Syntax Highlighting, cullmann

Reviewed By: Framework: Syntax Highlighting, cullmann

Subscribers: jriddell, cullmann, kde-frameworks-devel, kwrite-devel

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D23484

Details

Committed
cullmannAug 27 2019, 5:33 PM
Reviewer
Framework: Syntax Highlighting
Differential Revision
D23484: gcc naming conflict
Parents
R216:0ad8e84e4d1c: reST: handle some more corner cases, add an actual test file
Branches
Unknown
Tags
Unknown