KStartupInfo: drop dead code for removing quotes from data values
ClosedPublic

Authored by kossebau on Aug 25 2019, 6:19 AM.

Details

Summary

get_fields() already cares for removing the quotes, the bits in get_str()
are thus already operating on the final string, as well as it is broken
in the calculation of the text length to copy.

Possibly were left-over from initial code drafts, as all this logic was
already in the initial commit to kdelibs in e5b75f8409e7

Test Plan

Startup notification still works as before, quoted values like
Description="Launching Dolphin"
are still read in as before

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Aug 25 2019, 6:19 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 25 2019, 6:19 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Aug 25 2019, 6:19 AM
zzag accepted this revision.Sep 7 2019, 1:10 PM
This revision is now accepted and ready to land.Sep 7 2019, 1:10 PM
This revision was automatically updated to reflect the committed changes.