[take over] Add helpful buttons (mainly) for the Regular Expressions switch
ClosedPublic

Authored by mickaelbo on Aug 15 2019, 5:24 PM.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mickaelbo created this revision.Aug 15 2019, 5:24 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 15 2019, 5:24 PM
mickaelbo requested review of this revision.Aug 15 2019, 5:24 PM

I tried to remove inline comments.
From what I understood, there are still open questions :
-Do we keep the new buttons in the lineedit and the "snippets" in it and/or do we keep the snippets in the right click / add menu ? The snippets are in both menus for now. I have no personal opinion but I don't think I would have right clicked a lineedit if I didn't read the comments.
-Do we shorten the regexp button tooltip ? I prefer to do so.
-Do we update the Kate hoodbook ?

Hi,
thanks for taking care of this!

To the open questions:

-Do we keep the new buttons in the lineedit and the "snippets" in it and/or do we keep the snippets in the right click / add menu ? The snippets are in both menus for now. I have no personal opinion but I don't think I would have right clicked a lineedit if I didn't read the comments.

I would tend to keep them in both places.

-Do we shorten the regexp button tooltip ? I prefer to do so.

I would agree to shorten it, it is too intrusive the way it is (hiding a large part of the screen)

-Do we update the Kate hoodbook ?

I think the new stuff is more or less self-explaining and doesn't need extra manual coverage.

Ok, so as long as no one has another suggestion, the only remaining task is to choose a short tooltip.
English is not my mother tongue (I'm even capable of writing hoodbook instead of handbook) so please help me before I update the patch.
In order to keep it short, I suggest to give a hint about a single way to add a snippet, not both, example:

see available patterns in :
find or replace fields > right click > add

or

snippets available in the text fields right buttons

Perhaps Nate has some hints for the proper tooltip content.

Thanks for taking this over. My suggestion for the tooltip:

Old: "Use regular expressions"
New: "Enable regular expressions. Find help for regex syntax by using the buttons in the search and replace text fields."

Thanks for taking this over. My suggestion for the tooltip:
"Enable regular expressions. Find help for regex syntax by using the buttons in the search and replace text fields."

That seems good to me.

mickaelbo updated this revision to Diff 64067.Mon, Aug 19, 8:12 PM

Set the regexp button tooltip.

@gregormi: you clearly did all the work, you deserve to be the author if it matters to you.

Set the regexp button tooltip.

@gregormi: you clearly did all the work, you deserve to be the author if it matters to you.

Hello Mickael, thanks for asking. It should be possible to set me as author of the git commit.

I think I don't have the rights to apply a diff, the reviewers have to do so.
AFAIK, the patch is OK for everyone and setting gregormi as the author too.

cullmann accepted this revision.Sat, Aug 24, 2:34 PM

Then lets add this to our repo.
Thanks for taking care!

This revision is now accepted and ready to land.Sat, Aug 24, 2:34 PM
This revision was automatically updated to reflect the committed changes.