Make media control icons outline style instead of solid style
Needs ReviewPublic

Authored by guoyunhe on Aug 14 2019, 7:57 PM.

Details

Reviewers
ndavis
ngraham
Group Reviewers
VDG
Summary

In progress. If others think this is the correct way to do it, I can continue with other media control icons and all sizes.

From my understanding of KDE HIG, the icon should be outline style whenever possible.

Before:

After:

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15114
Build 15132: arc lint + arc unit
guoyunhe created this revision.Aug 14 2019, 7:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 14 2019, 7:57 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
guoyunhe requested review of this revision.Aug 14 2019, 7:57 PM
guoyunhe edited the summary of this revision. (Show Details)Aug 14 2019, 8:00 PM
ngraham requested changes to this revision.Aug 14 2019, 8:11 PM
ngraham added a subscriber: ngraham.

Hmm, not sure how I feel about this. I kind of like the filled-in versions.

Regardless, please re-add id="current-color-scheme" to the CSS, or else the icons will no longer change their colors to reflect the color scheme.

Also, if we want to do this, we'll need a companion patch for plasma-frameworks to adjust the equivalent icons in the Breeze Plasma theme too.

This revision now requires changes to proceed.Aug 14 2019, 8:11 PM
guoyunhe updated this revision to Diff 63762.Aug 14 2019, 8:13 PM

Correct SVG format

ndavis requested changes to this revision.Aug 14 2019, 8:19 PM

We don't strictly adhere to outline or filled style (for better or worse), sometimes making use of both styles in the same icon (e.g., view-list-icons). I think the general idea is that we normally use the line/outline style unless that puts the designer at a disadvantage. Icons can look messy with the outline style sometimes.

The standard media control symbols are rarely seen with an outline style in real graphical user interfaces. As far as I know, that style is never seen on physical media control buttons. I think changing the style would be more likely to make the icons look odd.

This revision now requires changes to proceed.Aug 14 2019, 8:19 PM
guoyunhe updated this revision to Diff 63763.Aug 14 2019, 8:42 PM

22px icons

Yes, I did a search on the internet and almost all popular music app use solid play/pause/stop icon.

The outline icon will look like this in JuK:

GB_2 added a subscriber: GB_2.Aug 14 2019, 8:49 PM


This would fix the unbalanced icon style in file operation notifications.