Add multiple datasets to target activity
Details
Details
Apply diff on multiple_dataset branch or pull branch gsoc_akshaychd_target_multiple_datasets
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Branch
- gsoc_akshaychd_target_multiple_datasets
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15908 Build 15926: arc lint + arc unit
Comment Actions
Tested, all works as expected.
There is still the star level associated with the datasets which need to be properly set, as on most of the datasets you added...
Beside this, the rest looks ok.
Comment Actions
I did two really small comments.
It misses the configuration in activity to be able to change the dataset directly.
Except this, it's good and ready to be merged when done, thank you!
src/activities/target/resource/1/Data.qml | ||
---|---|---|
2 | please, remove the empty first line on all dataset files | |
src/activities/target/resource/5/Data.qml | ||
39 | there are trailing spaces here (only this file) |
Comment Actions
Commited in https://commits.kde.org/gcompris/57985fcaf8191860eca3648f34d1919b8b450d42, thank you!