Details
Details
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I don't think it makes sense to have it in the third column, personally i think it'd make more sense in the first
I.e. first column is about names, third column is about paths.
So "Arial (subsituting with NimbusSans-Regular)" makes more sense to me than "/path/to/nimsussansregular (subsituting with NimbusSans-Regular)"
What do you think?
ui/propertiesdialog.cpp | ||
---|---|---|
361 | i18n please, with a context explaining the message |
ui/propertiesdialog.cpp | ||
---|---|---|
361 | no .arg() with i18n(), but parameters to it |
Comment Actions
Looks, good, i'll commit a slightly modified version that checks substituteName != fontname too, wanted to save us all the roundtrip