Add information about substituting font into properties dialog
ClosedPublic

Authored by jgrulich on Aug 8 2019, 10:10 AM.

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14892
Build 14910: arc lint + arc unit
jgrulich created this revision.Aug 8 2019, 10:10 AM
Restricted Application added a project: Okular. · View Herald TranscriptAug 8 2019, 10:10 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
jgrulich requested review of this revision.Aug 8 2019, 10:10 AM
aacid added a comment.Aug 8 2019, 5:50 PM

I don't think it makes sense to have it in the third column, personally i think it'd make more sense in the first

I.e. first column is about names, third column is about paths.

So "Arial (subsituting with NimbusSans-Regular)" makes more sense to me than "/path/to/nimsussansregular (subsituting with NimbusSans-Regular)"

What do you think?

ngraham added a subscriber: ngraham.Aug 8 2019, 6:38 PM

I agree, yeah.

jgrulich updated this revision to Diff 63387.Aug 9 2019, 3:41 AM

Move information about substituting fonto into the first column

pino added a subscriber: pino.Aug 9 2019, 6:56 AM
pino added inline comments.
ui/propertiesdialog.cpp
361

i18n please, with a context explaining the message

jgrulich updated this revision to Diff 63393.Aug 9 2019, 7:10 AM

Use translatable string

pino added inline comments.Aug 9 2019, 7:47 AM
ui/propertiesdialog.cpp
361

no .arg() with i18n(), but parameters to it

jgrulich updated this revision to Diff 63395.Aug 9 2019, 7:52 AM

Better use of i18nc API

aacid accepted this revision.Aug 9 2019, 11:57 PM

Looks, good, i'll commit a slightly modified version that checks substituteName != fontname too, wanted to save us all the roundtrip

This revision is now accepted and ready to land.Aug 9 2019, 11:57 PM
This revision was automatically updated to reflect the committed changes.