| Plasma |
Since shellManager was removed, we have a quite big regressions
of any other shell that isn't the desktop one not loading in any
way from SDDM, causing a big issue for plasma mobile or any shell
based on plasma mini shell, which we have several now not working
images based on.
This allows setting the plasma shell with an environment variable that
can be passed to startplasma (both wayland and x11) so we can have
dedicated session files for different shells
setting the env var makes plasma load the right shell, as adding the parameter to startplasma* in the session file
| No Linters Available |
| No Unit Test Coverage |
| Buildable 14879 | |
| Build 14897: arc lint + arc unit |
Please don't forget to document this: https://userbase.kde.org/KDE_System_Administration/Environment_Variables#Look_and_feel
| shell/main.cpp | ||
|---|---|---|
| 91 | MAY I SUGGEST RENAMING TO kde_plasma_shellpackage? | |
| shell/main.cpp | ||
|---|---|---|
| 91 | whoops sorry for caps. | |
This will always have this environment variable set up, which could become a bit weird if we end up supporting changing shells, because we'd have a value in the environment variable but the shell in another.
How about passing it through a file?
| shell/main.cpp | ||
|---|---|---|
| 91 | qEnvironmentVariable | |
if we end up supporting changing shells
We did, it got removed, because it wasn't used at all.
While i wouldn't mind for that feature to get back, using a temporary file wouldn't work, because as soon you have a crash and auto restart you get again on the default desktop shell.
to make the env var more clear, i would call it KDE_PLASMA_DEFAULT_SHELLPACKAGE
to say it's the default one, but not the really used one for sure