Differential D23031

more control on what shell is loaded
ClosedPublic
Actions

Authored by mart on Aug 8 2019, 1:50 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:69451047c0a3: more control on what shell is loaded
Summary

Since shellManager was removed, we have a quite big regressions
of any other shell that isn't the desktop one not loading in any
way from SDDM, causing a big issue for plasma mobile or any shell
based on plasma mini shell, which we have several now not working
images based on.

this allows for a shell being configured in plasmarc

Test Plan

shell specified in plasmarc loaded, loads the desktop if not specified

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Aug 8 2019, 1:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2019, 1:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Aug 8 2019, 1:50 PM
mart added a comment.Aug 8 2019, 1:51 PM

alternative to https://phabricator.kde.org/D23023
not sure what's better

apol accepted this revision.Aug 8 2019, 2:17 PM
apol added a subscriber: apol.

I like it much better

shell/main.cpp
92

plasmashellrc maybe?

This revision is now accepted and ready to land.Aug 8 2019, 2:17 PM
Closed by commit R120:69451047c0a3: more control on what shell is loaded (authored by mart). · Explain WhyAug 8 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.
mart marked an inline comment as done.Aug 8 2019, 4:28 PM

Revision Contents
Changeset List

PathPackages
Mshell/main.cpp (7 lines)

Diff 63367

View Options

shell/main.cpp

Loading...