always load about-distro in ctor
ClosedPublic
Actions

Authored by sitter on Jul 27 2016, 1:22 PM.

Details

Reviewers

sebas
cfeck

Commits

R102:8600dff7216c: always load about-distro in ctor

Summary

otherwise get a noticable delay during which we show dummy data. since
we only access on-disk content and only very little of it loading via ctor
should have next to no impact.

BUG: 366158

Diff Detail

Repository

R102 KInfoCenter

Branch

load-through-ctor

Lint

No Linters Available

Unit

No Unit Test Coverage

sitter updated this revision to Diff 5523.Jul 27 2016, 1:22 PM

sitter retitled this revision from to Update version number for 5.7.0 GIT_SILENT.

sitter updated this object.

sitter edited the test plan for this revision. (Show Details)

sitter added a reviewer: cfeck.

Restricted Application added a project: Plasma. · View Herald TranscriptJul 27 2016, 1:22 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sebas accepted this revision.Jul 27 2016, 1:24 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jul 27 2016, 1:24 PM

diff against right branch

This revision now requires review to proceed.Jul 27 2016, 1:24 PM

sitter retitled this revision from Update version number for 5.7.0 GIT_SILENT to always load about-distro in ctor.Jul 27 2016, 1:24 PM

sitter updated this object.

sebas accepted this revision.Jul 27 2016, 1:25 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jul 27 2016, 1:25 PM

Closed by commit R102:8600dff7216c: always load about-distro in ctor (authored by sitter). · Explain WhyJul 27 2016, 1:26 PM

This revision was automatically updated to reflect the committed changes.

rkflx mentioned this in D7087: Add "Copy Info" button to the About System KCM.Jun 30 2018, 9:50 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			Modules/about-distro/src/Module.cpp (6 lines)
M			Modules/fileindexermonitor/kcm_fileindexermonitor.desktop (3 lines)
M			Modules/fileindexermonitor/package/metadata.desktop (2 lines)
M			org.kde.kinfocenter.desktop (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5523	36341ea		Jul 27 2016, 1:22 PM	★	★
Diff 2	5524	b92968e	diff against right branch	Jul 27 2016, 1:24 PM	★	★
Diff 3	5525	b92968e	rKINFOCENTER8600dff7216c8f983ce991ac2e856b3aa7df28b7	Jul 27 2016, 1:25 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7086e59520dd	ce94ac5ee81c	b92968e46848	Harald Sitter	always load about-distro in ctor (Show More…)	Jul 27 2016, 1:17 PM
b92968e46848	72e03762cb3b	4f47f65981e1	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Jul 27 2016, 12:34 PM
4f47f65981e1	dd3ac676468e	15ad762ffcab	Jonathan Riddell	Update version number for 5.7.2 GIT_SILENT	Jul 19 2016, 10:41 AM
15ad762ffcab	7913c7a45e24	13046cf674ac	Jonathan Riddell	Update version number for 5.7.1 GIT_SILENT	Jul 12 2016, 9:30 AM
13046cf674ac	880dfb24fbf6	f9fe79bb2fe7	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Jun 30 2016, 1:05 PM
f9fe79bb2fe7	2f580520294f	36341ea6c287	David Edmundson	Update version number for 5.7.0 GIT_SILENT	Jun 30 2016, 11:51 AM