Fix typo in name of installed CMake Config: Deskop->Desktop

Authored by kossebau on Aug 7 2019, 4:16 PM.



Also no longer create unused file qqc2desktopstyle_version.h

Diff Detail

R858 Qt Quick Controls 2: Desktop Style
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Aug 7 2019, 4:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 7 2019, 4:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Aug 7 2019, 4:16 PM

Only current user known is plasma-desktop, from R119:737b114c2fa5bf0b01951eeb2eef22ce7fcdcfa1 No other hits seen on internet

No idea what is the most simple approach here, given KF releases are branchless, and Plasma has branches, and there are rolling distributions and non-rolling distributions, thus combining old KF and new Plasma, as well as new KF and new Plasma.

Perhaps install backward-compat version, and drop once Plasma 5.16 is no longer released due to Plasma 5.17 ?

Something to consider in time for Plasma 5.18, post 5.17.5 and before 5.17.90)

apol added a subscriber: apol.Nov 30 2019, 5:28 PM

Maybe you can install one with the typo and one without, so Plasma and whatever else can be ported and start doing things properly.

kossebau updated this revision to Diff 70633.Nov 30 2019, 6:37 PM
  • keep old CMake Config files installed
  • no longer create unused version.h file
kossebau edited the summary of this revision. (Show Details)Nov 30 2019, 6:38 PM

Np other opinion? Would then go with this in the next days...

davidedmundson accepted this revision.Dec 4 2019, 11:07 AM
This revision is now accepted and ready to land.Dec 4 2019, 11:07 AM
apol accepted this revision.Dec 4 2019, 12:21 PM
This revision was automatically updated to reflect the committed changes.