Offers the raw vcard property and allows getting a new raw vcard and refresh from it.
Depends on D22968
Details
Details
- Reviewers
jbbgameich bshah - Commits
- R732:3c1606386924: Make it possible to modify vcards
Modified my contacts using plasma-phonebook
Diff Detail
Diff Detail
- Repository
- R732 KPeople VCard Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/kpeoplevcard.cpp | ||
---|---|---|
38 | Shouldn't we potentially use the same location? Any specific reason to use different location? |
src/kpeoplevcard.cpp | ||
---|---|---|
38 | I don't really know, does it matter? If you think it's better I'm fine with it. At the moment, kdeconnect-sms already puts it into a subdirectory per device. |
Comment Actions
Seems fine to me. The vcard location probably doesn't really matter after all, and we can even change it later if necessary.