Differential D22969

Make it possible to modify vcards
ClosedPublic
Actions

Authored by apol on Aug 6 2019, 2:08 PM.

Details

Reviewers
jbbgameich
bshah
Commits
R732:3c1606386924: Make it possible to modify vcards
Summary

Offers the raw vcard property and allows getting a new raw vcard and refresh from it.
Depends on D22968

Test Plan

Modified my contacts using plasma-phonebook

Diff Detail

Repository
R732 KPeople VCard Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol requested review of this revision.Aug 6 2019, 2:08 PM
apol created this revision.
apol updated this revision to Diff 64316.Aug 22 2019, 3:40 PM

Make it possible to create new contacts

bshah added inline comments.Aug 23 2019, 4:26 PM
src/kpeoplevcard.cpp
38

Shouldn't we potentially use the same location? Any specific reason to use different location?

apol added inline comments.Aug 23 2019, 5:31 PM
src/kpeoplevcard.cpp
38

I don't really know, does it matter? If you think it's better I'm fine with it.

At the moment, kdeconnect-sms already puts it into a subdirectory per device.

jbbgameich accepted this revision.Aug 29 2019, 3:59 PM

Seems fine to me. The vcard location probably doesn't really matter after all, and we can even change it later if necessary.

This revision is now accepted and ready to land.Aug 29 2019, 3:59 PM
Closed by commit R732:3c1606386924: Make it possible to modify vcards (authored by apol). · Explain WhySep 3 2019, 12:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpeoplevcard.cpp (46 lines)

Diff 65280

View Options

src/kpeoplevcard.cpp

Loading...