Remove 'isExiting' logic from closing sequence
ClosedPublic

Authored by abika on Aug 4 2019, 5:25 PM.

Details

Summary

The flag was preventing Krusader from exiting if Krusader::queryClose() was
called but the exit was later cancelled (e.g. by a file save dialog of
KrViewer).

And the destructor Krusader::~Krusader() is not called on a SIGTERM signal
anyways.

FIXED: [ 409473 ] Computer shutdown gets cancelled
BUG: 409473

AND

Fix main window beeing closed to tray instead of exit on session logout

Test Plan

Tested exit behaviour on session logout and normal close request.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.Aug 4 2019, 5:25 PM
abika created this revision.
abika added a subscriber: Krusader.
asensi accepted this revision as: asensi.Aug 5 2019, 5:23 AM
asensi added a subscriber: asensi.

The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:

  • when its internal editor is not used,
  • when its internal editor has a file that is not saved,
  • when its internal editor has a file that is not saved and the computer is asked to reboot.

Other people can do their checks. Thanks, Alex!

This revision is now accepted and ready to land.Aug 5 2019, 5:23 AM
nmel accepted this revision.Fri, Sep 6, 6:16 AM
nmel added a subscriber: nmel.

Reviewed and tested (I'm using Plasma) - works good. Thanks for the fix, Alex!

Closed by commit R167:f690d5bb8fb9: Merge branch 'my-fix-session-logout' (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyMon, Sep 16, 2:57 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.Mon, Sep 16, 2:58 PM

Thanks, Toni and Nikita.