Differential D22871

Use better Workspace Behavior KCM title and icon
ClosedPublic
Actions

Authored by GB_2 on Aug 1 2019, 10:49 AM.

Details

Reviewers
filipf
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T11316: Systematic KCM reorganisation: Workspace section
Commits
R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon
Summary

Consistently call the KCM "General Behavior" and use preferences-desktop as the icon

Test Plan

Open the General Behavior KCM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 1 2019, 10:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2019, 10:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Aug 1 2019, 10:49 AM
GB_2 edited the test plan for this revision. (Show Details)Aug 1 2019, 10:50 AM
ngraham added a subscriber: ngraham.Aug 1 2019, 7:13 PM

Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all.

Also, does the docbook need to be updated?

GB_2 added a comment.Aug 1 2019, 7:30 PM
In D22871#505311, @ngraham wrote:

Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all.

I'll name it "General".

Also, does the docbook need to be updated?

Seems like it, will do that.

GB_2 updated this revision to Diff 62930.Aug 1 2019, 7:43 PM

Use name "General Behavior"

Restricted Application added a project: Documentation. · View Herald TranscriptAug 1 2019, 7:43 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
GB_2 retitled this revision from Use better Global Workspace Behavior KCM title and icon to Use better Workspace Behavior KCM title and icon.Aug 1 2019, 7:46 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the test plan for this revision. (Show Details)
filipf accepted this revision as: filipf.Aug 1 2019, 8:04 PM
filipf added a subscriber: filipf.

Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message.

doc/kcontrol/workspaceoptions/index.docbook
28

I'd drop the "the"

kcms/workspaceoptions/workspaceoptions.cpp
42

I'd drop the "the"

This revision is now accepted and ready to land.Aug 1 2019, 8:04 PM
ngraham added a comment.Aug 1 2019, 8:07 PM

If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me.

GB_2 added a comment.Aug 1 2019, 8:11 PM
In D22871#505360, @ngraham wrote:

If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me.

It's also the title shown in Kickoff/KRunner/etc.

ngraham accepted this revision.Aug 1 2019, 8:15 PM

Ah right. Okay, this is fine then.

GB_2 updated this revision to Diff 62933.Aug 1 2019, 8:16 PM

Drop word "the" in descriptions

Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber <bfeber@protonmail.com>, committed by GB_2). · Explain WhyAug 1 2019, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62935

View Options

doc/kcontrol/workspaceoptions/index.docbook

Loading...
View Options

kcms/workspaceoptions/kcm_workspace.desktop

Loading...
View Options

kcms/workspaceoptions/package/metadata.desktop

Loading...
View Options

kcms/workspaceoptions/workspaceoptions.cpp

Loading...