Differential D22800

Fix KService build on Android
ClosedPublic
Actions

Authored by apol on Jul 28 2019, 11:46 PM.

Details

Reviewers
sitter
vkrause
Group Reviewers
Frameworks
Commits
R309:99f21c7f7727: Fix KService build on Android
Summary

DrKonqi isn't working there, so ifdef it out

Test Plan

Built it

Diff Detail

Repository
R309 KService
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 28 2019, 11:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 28 2019, 11:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 28 2019, 11:46 PM
broulik added a subscriber: broulik.Jul 29 2019, 6:41 AM
broulik added inline comments.
src/kbuildsycoca/kbuildsycoca_main.cpp
26

Q_OS_ANDROID?

apol added inline comments.Jul 29 2019, 10:26 AM
src/kbuildsycoca/kbuildsycoca_main.cpp
26

Why?

vkrause accepted this revision.Jul 29 2019, 4:50 PM
vkrause added a subscriber: vkrause.

Change looks fine to me, no opinion on the platform define style.

This revision is now accepted and ready to land.Jul 29 2019, 4:50 PM
Closed by commit R309:99f21c7f7727: Fix KService build on Android (authored by apol). · Explain WhyJul 30 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62786

View Options

CMakeLists.txt

Loading...
View Options

src/kbuildsycoca/CMakeLists.txt

Loading...
View Options

src/kbuildsycoca/kbuildsycoca_main.cpp

Loading...