we are already looping trough screens, creating an activity
per screen is wrong
Details
Details
- Reviewers
davidedmundson ivan - Group Reviewers
Plasma - Commits
- R119:88e31e49967e: loop trough screens only once
R119:25863bd154a7: loop trough screens only once
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- phab/layoutjsloop
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
we are already looping through screens
Where? ShellCorona::loadDefaultLayout() (which runs this) is only called once - from load() and that's not per screen.
Comment Actions
var desktopsArray = desktopsForActivity(id); for (...)
This goes through all screens. There is one desktop/containment per screen.
The original script went to create an activity for each screen which is daft since plasma creates as many desktops as there are screens for *each* activity.