loop trough screens only once
ClosedPublic

Authored by mart on Jul 23 2016, 5:42 PM.

Details

Summary

we are already looping trough screens, creating an activity
per screen is wrong

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 5467.Jul 23 2016, 5:42 PM
mart retitled this revision from to loop trough screens only once.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptJul 23 2016, 5:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a reviewer: Plasma.Jul 23 2016, 5:43 PM
ivan accepted this revision.Jul 23 2016, 7:55 PM
ivan added a reviewer: ivan.
This revision is now accepted and ready to land.Jul 23 2016, 7:55 PM
davidedmundson requested changes to this revision.Jul 23 2016, 8:48 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

we are already looping through screens

Where? ShellCorona::loadDefaultLayout() (which runs this) is only called once - from load() and that's not per screen.

This revision now requires changes to proceed.Jul 23 2016, 8:48 PM
ivan added a comment.Jul 23 2016, 8:53 PM

we are already looping through screens

Where? ShellCorona::loadDefaultLayout() (which runs this) is only called once - from load() and that's not per screen.

var desktopsArray = desktopsForActivity(id); 
for (...)

This goes through all screens. There is one desktop/containment per screen.

The original script went to create an activity for each screen which is daft since plasma creates as many desktops as there are screens for *each* activity.

davidedmundson accepted this revision.Jul 23 2016, 9:16 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2016, 9:17 PM
This revision was automatically updated to reflect the committed changes.