Delete redundant and monochrome versions of applications-internet
ClosedPublic

Authored by ngraham on Jul 24 2019, 11:30 PM.

Details

Summary

applications-internet is the only category icon that has monochrome versions at small
sizes. In addition, there's a copy of it (same name and appearance) in preferences.

This patch corrects those two issues by deleting the monochrome and redundant versions.

Test Plan

Only the colorful version shows up in Cuttlefish:

With the patch to add icons to Discover's sidebar (D22716), all icons are now colorful:

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jul 24 2019, 11:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 24 2019, 11:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 24 2019, 11:30 PM
ndavis accepted this revision.EditedJul 25 2019, 5:05 AM

Ha! I was just about to start working on this myself. Obviously, I agree that this should be done. However, we should take note of all of the instances where applications-internet is currently used so that we can switch apps that intentionally use the monochrome version over to another icon like internet-services or globe.

https://lxr.kde.org/search?_filestring=&_string=applications-internet
In case the above link doesn't work for anyone, here's a list of all the references I found in the KDE repos that I've downloaded. It's not as complete as the info in the link above.

This revision is now accepted and ready to land.Jul 25 2019, 5:05 AM

Good idea. I'll submit patches for them and get them in before this lands.

All right, everything's been fixed. A goodly number of the users in that list were already using it appropriately for large colorful icons, so I didn't touch those.

This revision was automatically updated to reflect the committed changes.