Add icons to Categories, Installed, and Sources globaldrawer entries
ClosedPublic

Authored by leinir on Jul 24 2019, 1:38 PM.

Details

Summary

At some point, icons were removed from a number of entries in the global
drawer, but with the many other changes which have happened since then
this now leaves the sidebar looking somewhere between overly vacant and
broken (with some overweight toward the latter). This patch adds these
icons back in, as well as a couple of others, which results in a global
drawer which looks considerably more completely loaded.

This is furthermore based on feedback from the Plasma Mobile Todo[1] notes
entry, which at time of writing contains the following (amongst others):

Discover:
Global toolbar:

  • Installed and Sources should have icons
  • Categories should either have icons or be less indented

[1] https://notes.kde.org/p/plasma-mobile-todo

Parent Categories created by the category reader

Test Plan

See before without icons looks empty and just a tiny bit broken, and after
with icons included looks fully populated (screenshots incoming)

Before, no icons on the front page:

Before, no icons in the applications subcategory:

After, icons on the front page:

After, icons in the applications subcategory:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Jul 24 2019, 1:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2019, 1:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Jul 24 2019, 1:38 PM
leinir edited the test plan for this revision. (Show Details)Jul 24 2019, 1:40 PM
ngraham accepted this revision.Jul 24 2019, 2:09 PM
ngraham added a subscriber: ngraham.

Awesome! I've wanted this for a long time. LGTM. We can tweak the icons and their assignments in subsequent patches if necessary.

This revision is now accepted and ready to land.Jul 24 2019, 2:09 PM
apol accepted this revision.Jul 24 2019, 10:05 PM
This revision was automatically updated to reflect the committed changes.
GB_2 added a subscriber: GB_2.Sun, Jul 28, 6:26 AM
GB_2 added inline comments.
libdiscover/backends/KNSBackend/KNSBackend.cpp
214

I think we can use the icon plugins here.

ngraham added inline comments.Thu, Aug 1, 9:15 PM
libdiscover/backends/KNSBackend/KNSBackend.cpp
214

Submit a patch! :)