Differential D22718

Use Qt key names (e.g. Qt::SHIFT + Qt::Key_Left) for shortcuts
ClosedPublic
Actions

Authored by ngraham on Jul 24 2019, 2:17 PM.

Details

Reviewers
mgallien
astippich
Group Reviewers
Elisa
Commits
R255:9287cffc0bda: Use Qt key names (e.g. Qt::SHIFT + Qt::Key_Left) for shortcuts
Summary

While investigating https://bugs.kde.org/show_bug.cgi?id=410110, I found that the
keyboard shortcuts were being set using a non-standard method. This patch corrects
that and uses the standard Qt style.

I was hoping that this would fix https://bugs.kde.org/show_bug.cgi?id=410110, but it
does not.

Test Plan

Use Elisa in English; keyboard shortcuts still work

Diff Detail

Repository
R255 Elisa
Branch
use-qt-key-names-for-shortcuts (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14372
Build 14390: arc lint + arc unit
ngraham requested review of this revision.Jul 24 2019, 2:17 PM
ngraham created this revision.
astippich accepted this revision.Jul 24 2019, 4:41 PM
This revision is now accepted and ready to land.Jul 24 2019, 4:41 PM
Closed by commit R255:9287cffc0bda: Use Qt key names (e.g. Qt::SHIFT + Qt::Key_Left) for shortcuts (authored by ngraham). · Explain WhyJul 24 2019, 6:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/elisaapplication.cpp (6 lines)

Diff 62474

View Options

src/elisaapplication.cpp

Loading...