Sync scaling DPI from Plasma to SDDM
ClosedPublic

Authored by filipf on Jul 23 2019, 8:48 PM.

Details

Summary

This patch adds scaling to the list of Plasma settings that can be synced with SDDM.

Test Plan

Displays->Scale Display->set to 1.5
Login Screen(SDDM)->Advanced->pressed "Sync"
SDDM was big.

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 23 2019, 8:48 PM
Restricted Application added a project: Plasma. ยท View Herald TranscriptJul 23 2019, 8:48 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald Transcript
filipf requested review of this revision.Jul 23 2019, 8:48 PM
filipf edited the test plan for this revision. (Show Details)Jul 23 2019, 8:50 PM
filipf added reviewers: Plasma, davidedmundson, ngraham.
davidedmundson accepted this revision.Jul 23 2019, 9:58 PM
This revision is now accepted and ready to land.Jul 23 2019, 9:58 PM
ngraham accepted this revision.Jul 24 2019, 12:59 AM

๐Ÿ‘ ๐Ÿ‘

This revision was automatically updated to reflect the committed changes.

One potentially major issue that if I'm right needs fixing ASAP

src/advanceconfig.cpp
156

What are you going to write if this entry is missing?

I suspect you'll write just

"-dpi " into ServerArguments

and then X11 will run with "X11 -dpi" expect another argument and simply fail to load?

157

As a coding note it's useful to make sure the data in the variables matches their name.

In this case

"dpiValue" isn't just the DPI value, it's a string formatted as X server arguments "-dpi" here.

So I would suggest either renaming or (probably easier with the other fix) adding the "-dpi "prefix when you insert it into the map.