Differential D22636

Don't persist authentication
ClosedPublic
Actions

Authored by broulik on Jul 22 2019, 8:47 AM.

Details

Reviewers
fvogt
cullmann
aacid
Commits
R39:95016c51cfc3: Don't persist authentication
Summary

Otherwise subsequent save calls will not ask for a password, potentially allowing writing arbitrary files.

Test Plan

Hit Ctrl+S in kate numerous times, asked for password every time

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 22 2019, 8:47 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJul 22 2019, 8:47 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
broulik requested review of this revision.Jul 22 2019, 8:47 AM
cullmann accepted this revision.Jul 22 2019, 9:09 AM

Looks reasonable ;=)
And I did search this setting in the code, lol.

This revision is now accepted and ready to land.Jul 22 2019, 9:09 AM
Closed by commit R39:95016c51cfc3: Don't persist authentication (authored by broulik). · Explain WhyJul 22 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62290

View Options

src/buffer/org.kde.ktexteditor.katetextbuffer.actions

Loading...