This patch corrects a bug in the communication between the Focus module and the Capture module. If the Capture module requests the meridian flip to wait until a capture is completed AND after this capture a re-focus is triggered, all further state changes of the Focus module are ignored.
Details
Details
Place the mount close before the meridian and create a capture set that requests a re-focus every minute. When passing the meridian, the mount should execute the meridian flip as soon as capturing and re-focusing is completed.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Branch
- bugfix_autofocus_blocking_mf
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14167 Build 14185: arc lint + arc unit
kstars/ekos/capture/capture.cpp | ||
---|---|---|
3081 | This seems to be a relict that does not make sense any more. On the other side, it prevents during the meridian flip that state updates of the focuser are processed. |
kstars/ekos/capture/capture.cpp | ||
---|---|---|
3081 | Ok, now that meridian flip is handled elsewhere I guess it is no longer needed. But focus update during a meridian flip have had some negative effects. |
kstars/ekos/capture/capture.cpp | ||
---|---|---|
3081 | Yes, I know. But meanwhile this methods holds only status update functionality. So I think it‘s better to execute it no matter what happens with the meridian flip. |