Details

Reviewers

rizzitello
patrickelectric
broulik

Commits

R232:9d2eafd92ec3: Turn temperature() method to return pointer
R232:3fed09f8f204: Add method to return temperature pointer for qml
R232:b8054eecee5c: Declare property connectedPort as constants
R232:7451b81c6fb6: Use new temperature() on mainwindow

Summary

Add method to return temperature pointer for qml

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Diff Detail

Branch

temperatures

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13768
Build 13786: arc lint + arc unit

laysrodrigues requested review of this revision.Jul 8 2019, 9:52 PM

laysrodrigues created this revision.

Harbormaster completed remote builds in B13722: Diff 61375.Jul 8 2019, 9:52 PM

Register temperature pointer as q_property
Declare properties connectedPort and temperature as constants
Update gitignore
Update gitignore

Harbormaster completed remote builds in B13726: Diff 61380.Jul 9 2019, 12:04 AM

Update gitignore

Harbormaster completed remote builds in B13727: Diff 61381.Jul 9 2019, 12:05 AM

patrickelectric requested changes to this revision.Jul 9 2019, 12:09 AM

patrickelectric added inline comments.

src/core/atcore.cpp
975	Follow file style, brackets should be in new line.
src/core/atcore.h
256	We don't use prefix types in this project, try a more explicit way like just `temperature` or `temperaturePointer`.
src/core/machineinfo.h
124 ↗	(On Diff #61381)	It does not return a key, it returns a QString.

This revision now requires changes to proceed.Jul 9 2019, 12:09 AM

laysrodrigues marked 3 inline comments as done.Jul 9 2019, 2:07 AM

laysrodrigues added inline comments.

src/core/atcore.h
256	temperature doesn't work because of the shared_ptr. will use the second.

patrick suggestions

Harbormaster completed remote builds in B13731: Diff 61386.Jul 9 2019, 2:08 AM

Depends on D22331

rizzitello requested changes to this revision.Jul 9 2019, 11:37 AM

rizzitello added inline comments.

src/core/atcore.h
256	This is not needed, Edit the current one to return d->temperature.get() and update the clients to not use get for their calls.. Then everyone gets to save a bit of typing.

This revision now requires changes to proceed.Jul 9 2019, 11:37 AM

sith suggestions

Harbormaster completed remote builds in B13761: Diff 61431.Jul 9 2019, 5:06 PM

done

rizzitello requested changes to this revision.Jul 9 2019, 5:18 PM

rizzitello added inline comments.

src/core/atcore.cpp
974	Please add a new line here

This revision now requires changes to proceed.Jul 9 2019, 5:18 PM

rizzitello added a dependent revision: D22347: Use newer Atcore::Temperature() return.Jul 9 2019, 5:22 PM

laysrodrigues marked an inline comment as done.Jul 9 2019, 6:21 PM

New line

Harbormaster completed remote builds in B13768: Diff 61440.Jul 9 2019, 6:22 PM

Double check the base before merging.

patrickelectric accepted this revision.Jul 10 2019, 4:01 PM

This revision is now accepted and ready to land.Jul 10 2019, 4:01 PM

laysrodrigues closed this revision.Jul 10 2019, 4:11 PM

			Path	Packages
M			src/core/atcore.h (5 lines)
M			src/core/atcore.cpp (6 lines)
M			testclient/mainwindow.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61375	be839d4		Jul 8 2019, 9:52 PM	★	★
Diff 2	61380	be839d4	- Register temperature pointer as q_property	Jul 9 2019, 12:04 AM	★	★
Diff 3	61381	be839d4	- Update gitignore	Jul 9 2019, 12:05 AM	★	★
Diff 4	61386	6ad9da2	patrick suggestions	Jul 9 2019, 2:08 AM	★	★
Diff 5	61431	6a3d86a	sith suggestions	Jul 9 2019, 5:05 PM	★	★
Diff 6	61440	1a89e39	New line	Jul 9 2019, 6:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b8054eecee5c	90ef5d5c3492	7451b81c6fb6	Lays Rodrigues	Declare property connectedPort as constants (Show More…)	Jul 9 2019, 12:00 AM
7451b81c6fb6	e74752558d5a	9d2eafd92ec3	Lays Rodrigues	Use new temperature() on mainwindow (Show More…)	Jul 9 2019, 5:02 PM
9d2eafd92ec3	482f1ca583d7	1a89e3940946	Lays Rodrigues	Turn temperature() method to return pointer (Show More…)	Jul 8 2019, 9:51 PM

	Status	Author	Revision
	Closed	rizzitello	D22347 Use newer Atcore::Temperature() return
	Closed	laysrodrigues	D22334 Add method to return temperature pointer for qml

Add method to return temperature pointer for qml
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 61440

src/core/atcore.h

src/core/atcore.cpp

testclient/mainwindow.cpp

Add method to return temperature pointer for qmlClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 61440

src/core/atcore.h

src/core/atcore.cpp

testclient/mainwindow.cpp

Add method to return temperature pointer for qml
ClosedPublic
Actions

Revision Contents
Changeset List