Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
Add method to convert MachineInfo enum to string
Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
Details
Details
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Branch
- add_key_function
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13766 Build 13784: arc lint + arc unit
| src/core/machineinfo.cpp | ||
|---|---|---|
| 196 | Please add a new line here | |
| src/core/machineinfo.cpp | ||
|---|---|---|
| 173 | .first() will assert if the map is empty. Does this make sense to use for an associative container? | |
| 174 | Don't call keys() which creates a temporary list just to iterate it, also avoid double lookup. use iterators for (auto it = profile.begin(), end = profile.end(); it != end; ++it) {
m_settings->setValue(it.key(), it.value());
} | |
| src/core/machineinfo.h | ||
| 88 | const QVariantMap &? | |
| src/core/machineinfo.cpp | ||
|---|---|---|
| 190 | This can create elements if the key does not exist. use find(), assert that the result is != than end() | |
| src/core/machineinfo.cpp | ||
|---|---|---|
| 173 | I thought that I should use first() to get the first key in the map. What should I do instead? | |