Enable seek and volume control when hovering the sliders in the MediaPlayerControl.
Seek value is hardcoded to 10 seconds, while volume is controlled in steps of 5.
BUG: 408704
mgallien | |
ngraham |
Enable seek and volume control when hovering the sliders in the MediaPlayerControl.
Seek value is hardcoded to 10 seconds, while volume is controlled in steps of 5.
BUG: 408704
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
+1, but I found two little issues:
I have fixed the first issue. The second issue is a lot more difficult since the seeking and the volume change are working differently. The volume property of the actual audio player is bound to the slider value, while the seek works directly on the audio player and the slider is bound to the player. So the latter does a round trip. The fact that it is also done with two connected signals probably does not help.
Thanks, much better! Just one more little thing, then ship it.
src/qml/MediaPlayerControl.qml | ||
---|---|---|
311–312 | No need to set all three of these; just do width: elisaTheme.volumeSliderWidth once |