rename lsbRelease to prettyName and set it from os-release as well
ClosedPublic

Authored by sitter on Jun 28 2019, 12:55 PM.

Details

Summary

previously when lsb_release was not present or working we'd fall back
to os-release, but then not track the pretty name leading to the report
containing no Distribution value.
the more aptly named info variable is now set by both lsb_release and
os-release logic, ensuring that in both scenarios we have the distro
recorded in the report.

systeminformationtest now also checks that the pretty name is set when
testing on os-release (without lsb_release)

this also will allow us to eventually move to prefer os-release instead of
calling the external lsb_release script.

Test Plan

builds & passes

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 28 2019, 12:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2019, 12:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 28 2019, 12:55 PM
apol accepted this revision.Jul 1 2019, 1:42 PM
This revision is now accepted and ready to land.Jul 1 2019, 1:42 PM
This revision was automatically updated to reflect the committed changes.