test SystemInformation class
ClosedPublic
Actions

Authored by sitter on Jun 28 2019, 12:05 PM.

Details

Reviewers

apol

Group Reviewers

Plasma

Commits

R871:1f9eb46a697e: test SystemInformation class

Summary

has a new Config struct, encapsulates data we need to mangle for testing
new completeness state to make sure lsb_release has returned by the time we read data in the test
os-release fixture
lsb_release double

the os-release test has expected failure right now because the current
parser is in fact broken. needs porting to KOsRelease

Test Plan

builds && passes

Repository

R871 DrKonqi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Jun 28 2019, 12:05 PM

This revision is now accepted and ready to land.Jun 28 2019, 5:51 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/systeminformation.h (18 lines)
M		src/systeminformation.cpp (34 lines)
M		src/tests/CMakeLists.txt (15 lines)
A	M	src/tests/data/os-release (22 lines)
A	M	src/tests/lsb_release_double.c (27 lines)
A	M	src/tests/systeminformationtest.cpp (96 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60767	ae4b5bf		Jun 28 2019, 12:05 PM	★	★
Diff 2	60928	6602bc6	R871:1f9eb46a697e33a28adb362e7a6f26e606c1a212	Jul 1 2019, 1:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
aec53e2a4695	016f7cb18add	ae4b5bf2d170	Harald Sitter	test SystemInformation class (Show More…)	Jun 28 2019, 11:52 AM

Status	Author	Revision
Closed	sitter	D22141 rename lsbRelease to prettyName and set it from os-release as well
Closed	sitter	D22139 port to KOSRelease
Closed	sitter	D22137 test SystemInformation class
Closed	sitter	D22135 pack drkonqi into a transient static lib we can use for unit testing