Differential D22139

port to KOSRelease
ClosedPublic
Actions

Authored by sitter on Jun 28 2019, 12:41 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R871:7f3104b1a9d2: port to KOSRelease
Summary

this parses os-release correctly and also looks in both supported paths.
adjust test to now actually expect correct data

Test Plan

builds & passes

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 28 2019, 12:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2019, 12:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 28 2019, 12:41 PM
sitter added a dependency: D22137: test SystemInformation class.Jun 28 2019, 12:42 PM
sitter retitled this revision from port to KOSRelease from kcoreaddons to port to KOSRelease.
apol added a subscriber: apol.Jun 28 2019, 5:48 PM

T

src/systeminformation.cpp
249

How about removing the function and just using KOSRelease?

Or at least rename to readOSPrettyName

src/tests/systeminformationtest.cpp
85

Is it a problem with the data/os-release file?

apol accepted this revision.Jun 28 2019, 5:49 PM

I see most of these are addressed in D22141.

This revision is now accepted and ready to land.Jun 28 2019, 5:49 PM
Closed by commit R871:7f3104b1a9d2: port to KOSRelease (authored by sitter). · Explain WhyJul 1 2019, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60929

View Options

src/systeminformation.cpp

Loading...
View Options

src/tests/data/os-release

Loading...
View Options

src/tests/systeminformationtest.cpp

Loading...