Downgrade "Could not change permissions" dialog box to a qWarning
ClosedPublic

Authored by dfaure on Jun 23 2019, 10:00 AM.

Details

Summary

We already silenced that annoying messagebox for filesystems like
VFAT, NTFS, SMBFS etc. But it still happens in more tricky cases like
copying to a VirtualBox shared folder when the host is Windows
(i.e. this is NTFS but we can't know, mtab just says vboxsf,
and with a Linux host, vboxsf does support chmod).

All other similar warnings (chown/chgrp/utime failing) also just
lead to a qWarning, no point in annoying the user about this since
he/she can't do anything about it anyway.

In addition at the filesystem level chmod(2) doesn't even fail anymore
these days on VFAT/NTFS, it just fails silently.

Test Plan

Not really, since I couldn't actually get that warning on a native
Linux system, due to the last point above.

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13191
Build 13209: arc lint + arc unit
dfaure created this revision.Jun 23 2019, 10:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 23 2019, 10:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jun 23 2019, 10:00 AM
ngraham accepted this revision.Jun 23 2019, 10:01 AM
This revision is now accepted and ready to land.Jun 23 2019, 10:01 AM
dfaure closed this revision.Jun 23 2019, 12:17 PM