Diffusion KIO 1b4832c513da

Downgrade "Could not change permissions" dialog box to a qWarning

Authored by dfaure on Jun 23 2019, 9:47 AM.

Description

Downgrade "Could not change permissions" dialog box to a qWarning

Summary:
We already silenced that annoying messagebox for filesystems like
VFAT, NTFS, SMBFS etc. But it still happens in more tricky cases like
copying to a VirtualBox shared folder when the host is Windows
(i.e. this is NTFS but we can't know, mtab just says vboxsf,
and with a Linux host, vboxsf does support chmod).

All other similar warnings (chown/chgrp/utime failing) also just
lead to a qWarning, no point in annoying the user about this since
he/she can't do anything about it anyway.

In addition at the filesystem level chmod(2) doesn't even fail anymore
these days on VFAT/NTFS, it just fails silently.

Test Plan:
Not really, since I couldn't actually get that warning on a native
Linux system, due to the last point above.

Reviewers: chinmoyr, ngraham, maltek

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D22022