Differential D21938

Don't put HeaderBar in a parent Item
ClosedPublic
Actions

Authored by ngraham on Jun 20 2019, 4:34 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:ba4352456015: Don't put HeaderBar in a parent Item
Summary

It seems unnecessary to have this kind of indirection, and now the code is simplified.

Test Plan
  • Maximize headerbar
  • Look at main window

No visual changes in any case

Diff Detail

Repository
R255 Elisa
Branch
no-more-playerbar-parent-item (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13031
Build 13049: arc lint + arc unit
ngraham requested review of this revision.Jun 20 2019, 4:34 PM
ngraham created this revision.
mgallien accepted this revision.Jun 20 2019, 4:38 PM

Thanks

This revision is now accepted and ready to land.Jun 20 2019, 4:38 PM
Closed by commit R255:ba4352456015: Don't put HeaderBar in a parent Item (authored by Nate Graham <pointedstick@zoho.com>). · Explain WhyJun 20 2019, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/ElisaMainWindow.qml (148 lines)

Diff 60151

View Options

src/qml/ElisaMainWindow.qml

Loading...