Diffusion Elisa ba4352456015

Don't put HeaderBar in a parent Item
ba4352456015
Actions

Authored by Nate Graham <pointedstick@zoho.com> on Jun 20 2019, 4:33 PM.

Description

Don't put HeaderBar in a parent Item

Summary: It seems unnecessary to have this kind of indirection, and now the code is simplified.

Test Plan:

  • Maximize headerbar
  • Look at main window

No visual changes in any case

Reviewers: mgallien, Elisa

Reviewed By: mgallien, Elisa

Differential Revision: https://phabricator.kde.org/D21938

Details

Committed
Nate Graham <pointedstick@zoho.com>Jun 20 2019, 10:35 PM
Reviewer
Elisa
Differential Revision
D21938: Don't put HeaderBar in a parent Item
Parents
R255:93bcbd07f3cc: Revert "set implicitHeight and Width for MediaPlayerControl buttons"
Branches
Unknown
Tags
Unknown
Nate Graham <pointedstick@zoho.com> committed R255:ba4352456015: Don't put HeaderBar in a parent Item (authored by Nate Graham <pointedstick@zoho.com>).Jun 20 2019, 10:35 PM

Changes (1)

PathPackages
Msrc/qml/ElisaMainWindow.qml

R255:ba4352456015

View Options

src/qml/ElisaMainWindow.qml

Loading...