Port elisa kcm to qqc2
ClosedPublic

Authored by astippich on Jun 20 2019, 10:07 AM.

Details

Summary

Port to the local file kcm to qqc2, no visual and functional change
CCBUG: 405144

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jun 20 2019, 10:07 AM
astippich created this revision.

This is a CCBUG: 405144. You could probably upgrade it all the way to BUG: by porting the menu, too.

If you do so, you may hit https://bugs.kde.org/show_bug.cgi?id=405541. But maybe you can find a clever way around that (or just fix it) that I didn't find. :)

astippich edited the summary of this revision. (Show Details)Jun 20 2019, 1:22 PM

If you do so, you may hit https://bugs.kde.org/show_bug.cgi?id=405541. But maybe you can find a clever way around that (or just fix it) that I didn't find. :)

I ran into the same issue before but was also unable to fix it. The qqc2 menu does not show the shortcut, while the Qt.labs.platform menu does not show the icon. Will probably dedicate again some effort to it next as it is the only remaining component which is qqc1.

mgallien added inline comments.Thu, Jun 27, 3:30 PM
src/localFileConfiguration/package/contents/ui/main.qml
105

Please put this back. I do not feel like overshooting is of any value here.

ngraham requested changes to this revision.Fri, Jun 28, 2:28 PM
ngraham added inline comments.
src/localFileConfiguration/package/contents/ui/main.qml
105

In general I think this behavior should be controlled globally rather than determined by each app or even each scrollview (that just makes everything inconsistent). But you're right, it's unrelated to this patch and should not be changed here.

This revision now requires changes to proceed.Fri, Jun 28, 2:28 PM
astippich updated this revision to Diff 60829.Sat, Jun 29, 10:00 AM
  • cleanup and bring back boundsBehavior: Flickable.StopAtBounds
astippich added inline comments.Sat, Jun 29, 10:05 AM
src/localFileConfiguration/package/contents/ui/main.qml
105

flickableItem.boundsBehavior: Flickable.StopAtBounds
does not exist in qqc2. I cleaned up the scrollview according to what the the rest of elisa does

mgallien accepted this revision.Sat, Jun 29, 1:11 PM

Thanks

ngraham accepted this revision.Sat, Jun 29, 9:15 PM
This revision is now accepted and ready to land.Sat, Jun 29, 9:15 PM
This revision was automatically updated to reflect the committed changes.