While reporting the number of files is batched, the processed amount of bytes is relayed immediately, causing excessive DBus traffic when copying many small files.
Details
Details
- Reviewers
dfaure chinmoyr ngraham - Group Reviewers
Frameworks - Commits
- R241:a6d24222fdc1: [CopyJob] Batch reporting processed amount
Copied some stuff from PC to laptop and noticed massive dbus traffic on the jobviewinterface.
Tests still pass
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
OK in principle, but it might be that a setProcessedAmount(Bytes, totalSize) is missing at the end of the last file, so we don't end up with a progress dialog that looks like things are 99% done. Whether it's a real issue or not depends on the progress dialog implementation, but this code shouldn't make assumptions on that.
Comment Actions
Well, that would just be another symptom of the "doesn't call slotReport when finishing the call, no? cf. D19585