[PendingFileQueue] Use more accurate calculation of remaining time
ClosedPublic

Authored by bruns on Jun 13 2019, 11:22 PM.

Details

Summary

QTime::secsTo completely ignores any fractional (sub-second) part, i.e.
1.001 to 2.999 is a difference of 1 second, as is 1.999 to 2.001.

This leads to bursts when processing the pending queue, and also makes
testing more difficult, as the timeouts trigger with a jitter of
+/- 1 second.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 13 2019, 11:22 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 13 2019, 11:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 13 2019, 11:22 PM
ngraham accepted this revision.Jun 14 2019, 2:20 PM

+1, makes sense!

This revision is now accepted and ready to land.Jun 14 2019, 2:20 PM
This revision was automatically updated to reflect the committed changes.