simplify management of list and grid views and keep only one kind
ClosedPublic
Actions

Authored by mgallien on Jun 12 2019, 8:16 PM.

Details

Reviewers

Group Reviewers

Commits

R255:465f4859cb33: simplify management of list and grid views and keep only one kind
R255:e7b9644715bf: simplify management of list and grid views and keep only one kind

Summary

Factor all list views into a single one to decrease duplicated code.

fix display of single album list view

we now have a list and a grid generic view

DataListView is the new generic list view

Next one will be the file manager view.

Test Plan

tests are OK and manual testing shows no regressions.

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jun 12 2019, 8:16 PM

mgallien created this revision.

Harbormaster completed remote builds in B12745: Diff 59683.Jun 12 2019, 8:16 PM

Code change looks sane, and I also can detect no regressions!

This revision is now accepted and ready to land.Jun 13 2019, 8:18 PM

Closed by commit R255:e7b9644715bf: simplify management of list and grid views and keep only one kind (authored by mgallien). · Explain WhyJun 15 2019, 10:06 PM

This revision was automatically updated to reflect the committed changes.

This broke sorting in the album view (titles are now sorted, not track numbers)
Handling of multiple discs per album is also broken, but that seems not to be caused by this diff

In D21774#482625, @astippich wrote:

This broke sorting in the album view (titles are now sorted, not track numbers)

Yes, I have noticed it also. I will take care of it.

Handling of multiple discs per album is also broken, but that seems not to be caused by this diff

Yes, I can confirm it. I will take care of it.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (5 lines)
D	M	src/qml/AlbumView.qml (133 lines)
M		src/qml/ContentView.qml (6 lines)
V		src/qml/{DataListView.qml ← TracksView.qml}
D	M	src/qml/FrequentlyPlayedTracks.qml (123 lines)
D	M	src/qml/RecentlyPlayedTracks.qml (123 lines)
V		src/qml/{TracksView.qml → DataListView.qml}
M		src/resources.qrc (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59683	ee49bfc		Jun 12 2019, 8:16 PM	★	★
Diff 2	59893	a639223	R255:e7b9644715bf3bfe143b90159f9941d068ce4df0	Jun 15 2019, 9:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0401a00f5e0e	818b8cfc53aa	0cc8f2a7b904	Matthieu Gallien	we now have a list and a grid generic view (Show More…)	Jun 12 2019, 3:43 PM
0cc8f2a7b904	3934161bf53b	51cccc5553c2	Matthieu Gallien	fix display of single album list view	Jun 12 2019, 3:41 PM
51cccc5553c2	82fa34423e0f	ee49bfc0c554	Matthieu Gallien	simplify management of list and grid views and keep only one kind	Jun 11 2019, 9:24 PM