I took a guess for the fixed-in: field, sorry if it's wrong.

Very close! Since this is branched from master and it's a new feature with new strings, it will land on master, which will become 19.08.0

As for the UI, I think what might be a bit more elegant is rather than making this an explicit action, instead add a new radio button entry to the top of the menu named Default color scheme (<name of theme>). If that's technically difficult or you're against it though, I won't die on that hill. It's just a recommendation. :)

In D21699#477395, @ngraham wrote:

Very close! Since this is branched from master and it's a new feature with new strings, it will land on master, which will become 19.08.0

Okay.

As for the UI, I think what might be a bit more elegant is rather than making this an explicit action, instead add a new radio button entry to the top of the menu named Default color scheme (<name of theme>). If that's technically difficult or you're against it though, I won't die on that hill. It's just a recommendation. :)

The problem with that approach is that there will be two actions which do the same thing, in two different way:

• The action that's added by KColorSchemeManager (which adds an action for each available color scheme), and which we use to write the setting to katerc
• The action that resets the color scheme, i.e. makes kate follow the kde color scheme

It would be a bit confusing. I think of the new action added by this patch as a "Defaults" button in any of the kcm modules, just resetting a setting to the default value.

Perhaps we should open it up for VDG comment.

The current patch implements the following in Kate's Settings → Color theme menu:

(o) Breeze
( ) Breeze Dark
( ) Breeze High Contrast
( ) Breeze Light
( ) Honeycomb
( ) etc.
---
Reset to default KDE Color Scheme

My proposal is the following:

(o) Default KDE Color Scheme (Breeze)
---
( ) Breeze
( ) Breeze Dark
( ) Breeze High Contrast
( ) Breeze Light
( ) Honeycomb
( ) etc.

Or now that I think about it, even:

(o) Breeze (default)
( ) Breeze Dark
( ) Breeze High Contrast
( ) Breeze Light
( ) Honeycomb
( ) etc.

With the last proposal the user won't be able to set the the color scheme/theme to Breeze unconditionally in kate (i.e. if the scheme in systemsettings5 is changed kate will follow it).

In D21699#477688, @ahmadsamir wrote:

With the last proposal the user won't be able to set the the color scheme/theme to Breeze unconditionally in kate (i.e. if the scheme in systemsettings5 is changed kate will follow it).

Right. Is there any actual use case for this?

In D21699#477787, @ngraham wrote:

In D21699#477688, @ahmadsamir wrote:

With the last proposal the user won't be able to set the the color scheme/theme to Breeze unconditionally in kate (i.e. if the scheme in systemsettings5 is changed kate will follow it).

Right. Is there any actual use case for this?

The addition of the whole "Settings -> Color theme" feature in kate, i.e. a user who wants to set the color scheme of kate ui regardless of the color scheme of the rest of the system, is the use case. :)

In D21699#477809, @ahmadsamir wrote:

In D21699#477787, @ngraham wrote:

In D21699#477688, @ahmadsamir wrote:

With the last proposal the user won't be able to set the the color scheme/theme to Breeze unconditionally in kate (i.e. if the scheme in systemsettings5 is changed kate will follow it).

Right. Is there any actual use case for this?

The addition of the whole "Settings -> Color theme" feature in kate, i.e. a user who wants to set the color scheme of kate ui regardless of the color scheme of the rest of the system, is the use case. :)

That use case is already implemented by said user choosing a different color scheme though, right? For example, a user with Breeze Light set systemwide wants Kate to be Breeze Dark (or vice versa, or whatever).

What I'm asking is if it ever makes sense for the user to tell Kate to always use the Breeze Light color scheme when the system is itself already using the Breeze Light color scheme.

I just discovered/rediscovered D15645, which upstreams this menu into KConfigWidgets so it's available for every KDE app. I wonder if we should focus there instead?

In D21699#477813, @ngraham wrote:

[..]

What I'm asking is if it ever makes sense for the user to tell Kate to always use the Breeze Light color scheme when the system is itself already using the Breeze Light color scheme.

IMHO, the main point of this feature in kate is having a color scheme setting that is independent from the system color scheme setting.

Doesn't D15645 also do that, though?

kcolorschememanager has no methods to modify the config of the apps that make use of it; it only offers a menu with all the available kde color schemes on the system.

I'd prefer to just remove the whole thing, myself. But if this is something we decide should be in all KDE apps, then I'd accept it.

D15645 adds it systemwide to all KDE apps, which I strongly prefer.