remove phonon from deps if building for win32
ClosedPublic
Actions

Authored by brute4s99 on Jun 7 2019, 11:19 PM.

Details

Reviewers

Commits

Summary

Phonon is not a dependency for Windows 32 KNotification builds.

Repository

R877 Craft Blueprints for KDE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

brute4s99 requested review of this revision.Jun 7 2019, 11:19 PM

brute4s99 created this revision.

brute4s99 added a project: Craft.

LGTM

This revision is now accepted and ready to land.Jun 9 2019, 4:17 PM

I think we should wait until the code was released and then only version dependant.

This revision now requires changes to proceed.Jun 9 2019, 4:42 PM

umm, phonon isn't used for Windows notifications with/without the upcoming notifybysnoretoast back-end. Can we not land this?

ah ok, I thought it was linked without your code change

This revision is now accepted and ready to land.Jun 18 2019, 8:55 AM

awesome! landing this! 🎉

This revision was automatically updated to reflect the committed changes.

Reverted

			Path	Packages
M			kde/frameworks/tier3/knotifications/knotifications.py (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59373	87dd96a		Jun 7 2019, 11:19 PM	★	★
Diff 2	60011	319e159	R877:ecdf723052585218368fb15204915ba233b39525	Jun 18 2019, 8:57 AM	★	★

	Status	Author	Revision
	Closed	brute4s99	D21660 remove dbus for windows build and change audio dep logic
	Closed	brute4s99	D21657 remove phonon from deps if building for win32