Differential D21572

[UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)
ClosedPublic
Actions

Authored by bruns on Jun 4 2019, 8:53 AM.

Details

Reviewers
ngraham
astippich
poboiko
broulik
Group Reviewers
Baloo
Commits
R293:4fcc08d86881: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)
Summary

Avoid detach of QStringList in for loop.
Move invariant IndexingLevel out of the loop.

Test Plan

make

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 4 2019, 8:53 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 4 2019, 8:53 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 4 2019, 8:53 AM
broulik accepted this revision.Jun 4 2019, 8:55 AM
This revision is now accepted and ready to land.Jun 4 2019, 8:55 AM
Closed by commit R293:4fcc08d86881: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants) (authored by bruns). · Explain WhyJun 4 2019, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/unindexedfileindexer.cpp (6 lines)

Diff 59118

View Options

src/file/unindexedfileindexer.cpp

Loading...