Differential D21539

[FileIndexScheduler] Avoid emitting state changes multiple times
ClosedPublic
Actions

Authored by bruns on Jun 2 2019, 10:30 AM.

Details

Reviewers
ngraham
astippich
Group Reviewers
Baloo
Commits
R293:429c25772e4f: [FileIndexScheduler] Avoid emitting state changes multiple times
Summary

FileContentIndexer::quit() will cause emission of the done() signal,
triggering scheduleIndexing() later. scheduleIndexing() sets the
current indexer state on its own and also emits the stateChanged signal,
there is no need to do it from the various slots.

Test Plan

unplug AC, state change signal is still emitted

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 2 2019, 10:30 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 2 2019, 10:30 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 2 2019, 10:30 AM
ngraham accepted this revision.Jun 2 2019, 10:47 PM
This revision is now accepted and ready to land.Jun 2 2019, 10:47 PM
Closed by commit R293:429c25772e4f: [FileIndexScheduler] Avoid emitting state changes multiple times (authored by bruns). · Explain WhyJun 3 2019, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/fileindexscheduler.cpp (9 lines)

Diff 59042

View Options

src/file/fileindexscheduler.cpp

Loading...