| ngraham |
| Gwenview |
Use Purpose for the sharing menu.
The question is what to do with the old KIPI sharing infrastructure. It covers some services that Purpose doesn't. Getting rid of them without a replacement would probably upset some users. Ideally all KIPI plugins should be ported to Purpose, but that's a huge task.
Open an image, Share it
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Spectacle also supports both. We could probably do the same here in the meantime. I'm fine with replacing the current toolbar button with this though; it's much more useful, and Kipi still gets its own menu. Please also add the new action's to the file menu, context menu, and Operations panel. That way it's still accessible for people who don't want it in the toolbar.
Also, I found a bug: The send to Imgur action does not put the URL of the image into the clipboard, and there is no UI to display it, so for all intents and purposes it doesn't work.
| app/gwenviewui.rc | ||
|---|---|---|
| 3 | Need to bump the version whenever you change anything in here | |
| app/mainwindow.cpp | ||
| 515 | This needs setDelayed(false); set or else when it's added to the toolbar, clicking on it most of the button does nothing (you need to click on the arrow to make the menu appear). | |
Nice, that's better. Now we just need to add it to the file menu, context menu, and Operations panel.