[WIP/RFC] Use Purpose for sharing
ClosedPublic

Authored by nicolasfella on May 28 2019, 8:28 PM.

Details

Summary

Use Purpose for the sharing menu.

The question is what to do with the old KIPI sharing infrastructure. It covers some services that Purpose doesn't. Getting rid of them without a replacement would probably upset some users. Ideally all KIPI plugins should be ported to Purpose, but that's a huge task.

Test Plan

Open an image, Share it

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 28 2019, 8:28 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptMay 28 2019, 8:28 PM
nicolasfella requested review of this revision.May 28 2019, 8:28 PM
ngraham requested changes to this revision.May 28 2019, 9:15 PM
ngraham added a subscriber: ngraham.

Spectacle also supports both. We could probably do the same here in the meantime. I'm fine with replacing the current toolbar button with this though; it's much more useful, and Kipi still gets its own menu. Please also add the new action's to the file menu, context menu, and Operations panel. That way it's still accessible for people who don't want it in the toolbar.

Also, I found a bug: The send to Imgur action does not put the URL of the image into the clipboard, and there is no UI to display it, so for all intents and purposes it doesn't work.

app/gwenviewui.rc
3

Need to bump the version whenever you change anything in here

app/mainwindow.cpp
515

This needs setDelayed(false); set or else when it's added to the toolbar, clicking on it most of the button does nothing (you need to click on the arrow to make the menu appear).

This revision now requires changes to proceed.May 28 2019, 9:15 PM

Friendly ping!

Nice, that's better. Now we just need to add it to the file menu, context menu, and Operations panel.

Nice, that's better. Now we just need to add it to the file menu, context menu, and Operations panel.

I'd say that's stuff for another patch

ngraham accepted this revision.Sat, Jun 22, 2:23 PM

All right, sure

This revision is now accepted and ready to land.Sat, Jun 22, 2:23 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Sun, Jun 23, 11:45 AM

Could this be made an optional dependency like it is in Okular and Spectacle?

cfeck added a comment.Wed, Jul 3, 7:35 PM

I added https://phabricator.kde.org/D22251 for making it optional.