Differential D21398

Correctly crop Sony's embedded thumbnails
ClosedPublic
Actions

Authored by tommo on May 25 2019, 12:38 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:d7ae0b6f4d40: Correctly crop Sony's embedded thumbnails

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tommo requested review of this revision.May 25 2019, 12:38 PM
tommo created this revision.
tommo added a comment.EditedMay 25 2019, 12:49 PM

Works for usual and panorama images, e.g.:

ngraham added a subscriber: ngraham.May 26 2019, 3:43 PM

All of these new variables can be const

tommo updated this revision to Diff 58978.Jun 1 2019, 11:44 AM

Constness.

ngraham accepted this revision.Jun 2 2019, 9:21 PM

Thanks!

This revision is now accepted and ready to land.Jun 2 2019, 9:21 PM
Closed by commit R260:d7ae0b6f4d40: Correctly crop Sony's embedded thumbnails (authored by tommo, committed by ngraham). · Explain WhyJun 2 2019, 9:23 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Dec 21 2019, 8:29 AM
cfeck added inline comments.
lib/jpegcontent.cpp
590

This division causes bug 414631.

ngraham mentioned this in D26527: Fix divide-by-zero crash.Jan 8 2020, 4:24 PM
ngraham added inline comments.
lib/jpegcontent.cpp
590

Submitted D26527 to fix this.

Revision Contents
Changeset List

PathPackages
Mlib/jpegcontent.cpp (23 lines)

Diff 59040

View Options

lib/jpegcontent.cpp

Loading...