[scripts] Drop enforcedeco script
ClosedPublic

Authored by zzag on May 23 2019, 8:28 PM.

Details

Summary

GTK clients check whether _GTK_FRAME_EXTENTS is in _NET_SUPPORTED, so we
don't need this script anymore.

Also, because GTK clients don't set shadow extents, this script
is doing nothing.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.May 23 2019, 8:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 23 2019, 8:28 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 23 2019, 8:28 PM

+1
(not sure about removing that property since it's somewhat public API isn't it?)

zzag added a comment.May 24 2019, 10:46 AM

(not sure about removing that property since it's somewhat public API isn't it?)

I think that's fine because

(a) as far as I know, only this script uses clientSideDecorated property
(b) it's always false

+1 for removing things that don't work and have no effect.

However the problem that this script was trying to solve is real. There's actually a different script (written by @jackg) on store.kde.org that does a great job of it: https://store.kde.org/p/1235093/ It works great and I use it myself. I wonder if we might consider upstreaming that and shipping it by default like we did for the current script you're removing. It results in quite an improvement to the GTK3 headerbar app user experience.

zzag added a comment.May 24 2019, 1:31 PM

The proposed script contains a hack that is not suitable for upstream.

zzag updated this revision to Diff 60811.EditedFri, Jun 28, 10:18 PM

Don't set the world on fire, only drop the script.

davidedmundson accepted this revision.Fri, Jun 28, 10:19 PM
This revision is now accepted and ready to land.Fri, Jun 28, 10:19 PM
This revision was automatically updated to reflect the committed changes.