GTK clients check whether _GTK_FRAME_EXTENTS is in _NET_SUPPORTED, so we
don't need this script anymore.
Also, because GTK clients don't set shadow extents, this script
is doing nothing.
davidedmundson |
KWin |
GTK clients check whether _GTK_FRAME_EXTENTS is in _NET_SUPPORTED, so we
don't need this script anymore.
Also, because GTK clients don't set shadow extents, this script
is doing nothing.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
(not sure about removing that property since it's somewhat public API isn't it?)
I think that's fine because
(a) as far as I know, only this script uses clientSideDecorated property
(b) it's always false
+1 for removing things that don't work and have no effect.
However the problem that this script was trying to solve is real. There's actually a different script (written by @jackg) on store.kde.org that does a great job of it: https://store.kde.org/p/1235093/ It works great and I use it myself. I wonder if we might consider upstreaming that and shipping it by default like we did for the current script you're removing. It results in quite an improvement to the GTK3 headerbar app user experience.