Differential D21349

Use simply configure_file to generate the plasmacomponents3 files
ClosedPublic
Actions

Authored by kossebau on May 22 2019, 6:12 PM.

Details

Reviewers
mart
apol
Group Reviewers
Plasma
Commits
R242:b0850b1f6fc7: Use simply configure_file to generate the plasmacomponents3 files

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 22 2019, 6:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 22 2019, 6:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 22 2019, 6:12 PM
apol added a subscriber: apol.May 22 2019, 6:25 PM

Won't it need installing then?
What are we fixing here?

kossebau added a comment.May 22 2019, 6:35 PM
In D21349#468698, @apol wrote:

Won't it need installing then?

It is installed as before, by code below

install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/plasmacomponents3/ DESTINATION ${KDE_INSTALL_QMLDIR}/QtQuick/Controls.2/Plasma)

and then the one partially also copying over for other needs once more.

What are we fixing here?

The use of the not that much right macro to use for the need. Which here is to apply QQC2_VERSION to the qml template files and nothing more, by what I saw?

apol accepted this revision.May 22 2019, 9:43 PM
This revision is now accepted and ready to land.May 22 2019, 9:43 PM
Closed by commit R242:b0850b1f6fc7: Use simply configure_file to generate the plasmacomponents3 files (authored by kossebau). · Explain WhyMay 22 2019, 10:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58516

View Options

src/declarativeimports/CMakeLists.txt

Loading...