Differential D21218

Create new icon for Knights based on Anjuta's icon
ClosedPublic
Actions

Authored by ngraham on May 14 2019, 4:16 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:2732215b8681: Add dark version of new Knights icon which escaped from my previous commit
R266:5a2dfb5804ba: Create new icon for Knights based on Anjuta's icon
Summary

Knights has a Breeze icon, but it's not very Breeze-style.

This patch adds a new one that's based on Anjuta's icon, with tweaks to make
it better-resemble the original.

CCBUG: 407527

Test Plan

Before:


After:

Diff Detail

Repository
R266 Breeze Icons
Branch
anjuta-to-knights (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11839
Build 11857: arc lint + arc unit
ngraham created this revision.May 14 2019, 4:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 14 2019, 4:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 14 2019, 4:16 PM
ngraham edited the summary of this revision. (Show Details)May 14 2019, 4:18 PM
ngraham edited the test plan for this revision. (Show Details)
ognarb added a subscriber: ognarb.May 14 2019, 4:53 PM

Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original.

ndavis added a subscriber: ndavis.May 14 2019, 5:06 PM
In D21218#465340, @ognarb wrote:

Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original.

I think this is probably better and might prevent confusion for existing Knights users.

ngraham updated this revision to Diff 58096.May 14 2019, 5:55 PM

New Knights icon based on Anjuta's

ngraham retitled this revision from Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point to Create new icon for Knights based on Anjuta's icon.May 14 2019, 5:56 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ndavis requested changes to this revision.May 15 2019, 1:11 AM

Once you've optimized the SVGs, I'll approve this.

https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

This revision now requires changes to proceed.May 15 2019, 1:11 AM
ngraham updated this revision to Diff 58105.May 15 2019, 2:27 AM

Optimize with scour

ndavis accepted this revision.May 15 2019, 2:35 AM

LGTM

This revision is now accepted and ready to land.May 15 2019, 2:35 AM
ngraham edited the summary of this revision. (Show Details)May 15 2019, 2:39 AM
Closed by commit R266:5a2dfb5804ba: Create new icon for Knights based on Anjuta's icon (authored by ngraham). · Explain WhyMay 15 2019, 2:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMicons-dark/apps/48/knights.svg (138 lines)
Micons/apps/48/knights.svg (206 lines)

Diff 58096

View Options

icons-dark/apps/48/knights.svg

Loading...
View Options

icons/apps/48/knights.svg

Loading...