Differential D21107

Replace qVariantFromValue with QVariant::fromValue
ClosedPublic
Actions

Authored by nicolasfella on May 9 2019, 8:58 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
Commits
R237:a40f6e9eb287: Replace qVariantFromValue with QVariant::fromValue
Summary

qVariantFromValue is obsolete (https://doc.qt.io/qt-5/qvariant-obsolete.html#qVariantFromValue-1) and causes build failure in KActivities and KEmoticons with current Qt dev

Test Plan

KActivities and KEmoticons build again with current Qt dev

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 9 2019, 8:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 9 2019, 8:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.May 9 2019, 8:58 PM
apol accepted this revision.May 9 2019, 11:10 PM
apol added a subscriber: apol.

Maybe it could make sense to have a clazy fixit for it?

This revision is now accepted and ready to land.May 9 2019, 11:10 PM
nicolasfella added a comment.May 9 2019, 11:24 PM
In D21107#463157, @apol wrote:

Maybe it could make sense to have a clazy fixit for it?

That sound like a good idea. A quick search showed that qVariantFromValue is used in lots of KDE code
I'll give it a try

Closed by commit R237:a40f6e9eb287: Replace qVariantFromValue with QVariant::fromValue (authored by nicolasfella). · Explain WhyMay 9 2019, 11:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kconfiggroup.h (8 lines)

Diff 57828

View Options

src/core/kconfiggroup.h

Loading...